Add hold for firmware and minor cleanup

Makefile

@@ -19,5 +19,5 @@ image:
 
 clean:
 	rm -rf /tmp/packer-builder-arm-image
-	rm -f pwnagotchi-raspbian-lite.img
+	rm -f pwnagotchi-raspbian-lite-*.zip pwnagotchi-raspbian-lite-*.img pwnagotchi-raspbian-lite-*.sha256
 	rm -rf builder/output-pwnagotchi  builder/packer_cache

builder/pwnagotchi.yml

@@ -33,6 +33,12 @@
         url: "https://github.com/bettercap/bettercap/releases/download/v2.25/bettercap_linux_armv6l_2.25.zip"
         ui: "https://github.com/bettercap/ui/releases/download/v1.3.0/ui.zip"
       apt:
+        hold:
+          - firmware-atheros
+          - firmware-brcm80211
+          - firmware-libertas
+          - firmware-misc-nonfree
+          - firmware-realtek
         remove:
           - rasberrypi-net-mods
           - dhcpcd5
@@ -118,6 +124,12 @@
       repo: deb http://http.re4son-kernel.com/re4son/ kali-pi main
       state: present
 
+  - name: add firmware packages to hold
+    dpkg_selections:
+      name: "{{ item }}"
+      selection: hold
+    with_items: "{{ packages.apt.hold }}"
+
   - name: update apt package cache
     apt:
       update_cache: yes
@@ -343,34 +355,48 @@
           /opt/vc/bin/tvservice -o
         fi
 
-  - name: create /etc/pwnagotchi/config.yml
+  - name: create /etc/pwnagotchi folder
-    blockinfile:
+    file:
+      path: /etc/pwnagotchi
+      state: directory
+
+  - name: check if user configuration exists
+    stat:
       path: /etc/pwnagotchi/config.yml
-      create: yes
+    register: user_config
-      block: |
+
-        # put here your custom configuration overrides
+  - name: create /etc/pwnagotchi/config.yml
+    copy:
+      dest: /etc/pwnagotchi/config.yml
+      content: |
+        # Add your configuration overrides on this file any configuration changes done to defaults.yml will be lost!
+        # Example:
+        #
+        # ui:
+        #   display:
+        #     type: 'inkyphat'
+        #     color: 'black'
+        #
+    when: not user_config.stat.exists
 
   - name: configure lo interface
-    blockinfile:
+    copy:
-      path: /etc/network/interfaces.d/lo-cfg
+      dest: /etc/network/interfaces.d/lo-cfg
-      create: yes
+      content: |
-      block: |
         auto lo
         iface lo inet loopback
 
   - name: configure wlan interface
-    blockinfile:
+    copy:
-      path: /etc/network/interfaces.d/wlan0-cfg
+      dest: /etc/network/interfaces.d/wlan0-cfg
-      create: yes
+      content: |
-      block: |
         allow-hotplug wlan0
         iface wlan0 inet static
 
   - name: configure usb interface
-    blockinfile:
+    copy:
-      path: /etc/network/interfaces.d/usb0-cfg
+      dest: /etc/network/interfaces.d/usb0-cfg
-      create: yes
+      content: |
-      block: |
         allow-hotplug usb0
         iface usb0 inet static
           address 10.0.0.2
@@ -380,10 +406,9 @@
           gateway 10.0.0.1
 
   - name: configure eth0 interface (pi2/3/4)
-    blockinfile:
+    copy:
-      path: /etc/network/interfaces.d/eth0-cfg
+      dest: /etc/network/interfaces.d/eth0-cfg
-      create: yes
+      content: |
-      block: |
         allow-hotplug eth0
         iface eth0 inet dhcp
 
@@ -397,8 +422,7 @@
       dest: /boot/config.txt
       insertafter: EOF
       line: '{{ item }}'
-    with_items:
+    with_items: "{{system.boot_options}}"
-      - "{{system.boot_options}}"
 
   - name: change root partition
     replace:
@@ -500,5 +524,3 @@
   - name: reload systemd services
     systemd:
       daemon_reload: yes
-
-