From 61e5872229a75cbb74643b925c85489446acb451 Mon Sep 17 00:00:00 2001 From: Silsha Fux Date: Tue, 21 Jan 2020 17:41:14 +0100 Subject: [PATCH] Prevent saving gps file without coordinates Signed-off-by: Silsha Fux --- pwnagotchi/plugins/default/gps.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/pwnagotchi/plugins/default/gps.py b/pwnagotchi/plugins/default/gps.py index d3cce8d..60ee86f 100644 --- a/pwnagotchi/plugins/default/gps.py +++ b/pwnagotchi/plugins/default/gps.py @@ -44,9 +44,15 @@ class GPS(plugins.Plugin): self.coordinates = info["gps"] gps_filename = filename.replace(".pcap", ".gps.json") - logging.info(f"saving GPS to {gps_filename} ({self.coordinates})") - with open(gps_filename, "w+t") as fp: - json.dump(self.coordinates, fp) + if self.coordinates and all([ + # avoid 0.000... measurements + self.coordinates["Latitude"], self.coordinates["Longitude"] + ]): + logging.info(f"saving GPS to {gps_filename} ({self.coordinates})") + with open(gps_filename, "w+t") as fp: + json.dump(self.coordinates, fp) + else: + logging.info("not saving GPS. Couldn't find location.") def on_ui_setup(self, ui): # add coordinates for other displays